Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VX-115: slack notification #10

Merged
merged 1 commit into from
Jun 19, 2018
Merged

VX-115: slack notification #10

merged 1 commit into from
Jun 19, 2018

Conversation

yarencheng
Copy link
Contributor

No description provided.

@yarencheng yarencheng force-pushed the aren/VX-115 branch 12 times, most recently from 5a273f6 to 0c7c243 Compare June 19, 2018 07:27
@yarencheng yarencheng changed the title [WIP] VX-115: slack notification VX-115: slack notification Jun 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #10   +/-   ##
======================================
  Coverage    46.9%   46.9%           
======================================
  Files          11      11           
  Lines         307     307           
======================================
  Hits          144     144           
  Misses        152     152           
  Partials       11      11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8309e...875ee2d. Read the comment docs.

Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit 345f29d into master Jun 19, 2018
@hwchiu hwchiu deleted the aren/VX-115 branch June 19, 2018 09:17
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
VX-115: slack notification
Former-commit-id: d331a083f57d9a2e670bc9e8e33488aeaf1e434a [formerly 345f29d]
Former-commit-id: feccf4eefa2d2e11ac609f92ef091bf686938bea
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
VX-115: slack notification
Former-commit-id: d331a083f57d9a2e670bc9e8e33488aeaf1e434a [formerly d331a083f57d9a2e670bc9e8e33488aeaf1e434a [formerly 345f29d]]
Former-commit-id: feccf4eefa2d2e11ac609f92ef091bf686938bea
Former-commit-id: ebe0819
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants