Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add valitation tag #100

Merged
merged 1 commit into from
Jul 16, 2018
Merged

add valitation tag #100

merged 1 commit into from
Jul 16, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@John-Lin John-Lin force-pushed the johnlin/volume-entity-validate branch from 31370ea to 1537f90 Compare July 16, 2018 06:58
@John-Lin John-Lin force-pushed the johnlin/volume-entity-validate branch from 1537f90 to 36bf5e9 Compare July 16, 2018 07:39
@codecov-io
Copy link

Codecov Report

Merging #100 into develop will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #100      +/-   ##
===========================================
- Coverage    73.32%   73.19%   -0.14%     
===========================================
  Files           35       35              
  Lines         1586     1589       +3     
===========================================
  Hits          1163     1163              
- Misses         351      353       +2     
- Partials        72       73       +1
Impacted Files Coverage Δ
src/server/handler_volume.go 76.47% <0%> (-2.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14db765...36bf5e9. Read the comment docs.

hwchiu
hwchiu approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit 816c364 into develop Jul 16, 2018
@hwchiu hwchiu deleted the johnlin/volume-entity-validate branch July 16, 2018 07:55
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #100 from linkernetworks/johnlin/volume-entity-val…
fe2e6a8 
…idate

add valitation tag

Former-commit-id: 2fae4f8298606e7011b0f8d50e80390da0021efd [formerly 816c364]
Former-commit-id: a9ce5ebbe1ab42591bc48b98d655da69e58dab5a
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #100 from linkernetworks/johnlin/volume-entity-val…
d2814b7 
…idate

add valitation tag

Former-commit-id: 2fae4f8298606e7011b0f8d50e80390da0021efd [formerly 2fae4f8298606e7011b0f8d50e80390da0021efd [formerly 816c364]]
Former-commit-id: a9ce5ebbe1ab42591bc48b98d655da69e58dab5a
Former-commit-id: fe2e6a8
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #100 from linkernetworks/johnlin/volume-entity-val…
8920761 
…idate

add valitation tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@John-Lin @codecov-io @hwchiu @chenyunchen