Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VX-173 Add default namespace #103

Merged
merged 3 commits into from
Jul 16, 2018
Merged

VX-173 Add default namespace #103

merged 3 commits into from
Jul 16, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@chenyunchen chenyunchen force-pushed the alex/AddDefaultNamespace branch from 50691d8 to 79b23c0 Compare July 16, 2018 07:46
@chenyunchen chenyunchen force-pushed the alex/AddDefaultNamespace branch from 79b23c0 to a791c5d Compare July 16, 2018 07:51
@codecov-io
Copy link

codecov-io commented Jul 16, 2018 •
edited
Loading

Codecov Report

Merging #103 into develop will increase coverage by 1.59%.
The diff coverage is 97.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
+ Coverage    73.32%   74.92%   +1.59%     
===========================================
  Files           35       35              
  Lines         1586     1711     +125     
===========================================
+ Hits          1163     1282     +119     
- Misses         351      354       +3     
- Partials        72       75       +3
Impacted Files Coverage Δ
src/prometheuscontroller/expression.go 87.5% <100%> (+1.64%) ⬆️
src/kubernetes/services.go 86.66% <100%> (ø) ⬆️
src/pod/pod.go 95.52% <100%> (+0.13%) ⬆️
src/kubernetes/deployment.go 85.71% <100%> (ø) ⬆️
src/kubernetes/pvc.go 86.66% <100%> (ø) ⬆️
src/kubernetes/pods.go 86.36% <100%> (ø) ⬆️
src/volume/volume.go 92.3% <100%> (+0.3%) ⬆️
src/kubernetes/kubectl.go 100% <100%> (ø) ⬆️
src/storageprovider/nfs.go 92.47% <75%> (+0.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14db765...c6cd5bc. Read the comment docs.

@hwchiu hwchiu merged commit dbe6713 into develop Jul 16, 2018
@hwchiu hwchiu deleted the alex/AddDefaultNamespace branch July 16, 2018 08:35
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #103 from linkernetworks/alex/AddDefaultNamespace
af95123 
VX-173 Add default namespace

Former-commit-id: 8e32faf1f5730a79fcd08d08c3aabdd4113233a6 [formerly dbe6713]
Former-commit-id: 84091ce6344abf0fe7ed600de3a2d6d8907aae7d
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #103 from linkernetworks/alex/AddDefaultNamespace
cc152ea 
VX-173 Add default namespace

Former-commit-id: 8e32faf1f5730a79fcd08d08c3aabdd4113233a6 [formerly 8e32faf1f5730a79fcd08d08c3aabdd4113233a6 [formerly dbe6713]]
Former-commit-id: 84091ce6344abf0fe7ed600de3a2d6d8907aae7d
Former-commit-id: af95123
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #103 from linkernetworks/alex/AddDefaultNamespace
9f2ebe4 
VX-173 Add default namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyunchen @codecov-io @hwchiu @John-Lin