Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Add pci id column #104

Merged
merged 1 commit into from
Jul 16, 2018
Merged

DEV: Add pci id column #104

merged 1 commit into from
Jul 16, 2018

Conversation

WakeupTsai
Copy link
Contributor

If the NIC does't have a pic id, then the value will be an empty string

hwchiu
hwchiu approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jul 16, 2018 •
edited
Loading

Codecov Report

Merging #104 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
+ Coverage    73.32%   73.36%   +0.03%     
===========================================
  Files           35       35              
  Lines         1586     1588       +2     
===========================================
+ Hits          1163     1165       +2     
  Misses         351      351              
  Partials        72       72
Impacted Files Coverage Δ
src/prometheuscontroller/expression.go 85.95% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14db765...afc940e. Read the comment docs.

@hwchiu hwchiu merged commit 1b9319b into develop Jul 16, 2018
@hwchiu hwchiu deleted the phstsai/pciID branch July 16, 2018 07:58
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #104 from linkernetworks/phstsai/pciID
2d322dc 
DEV: Add pci id column
Former-commit-id: ae347c6e5676bd5c9c5889249f3c171b18692427 [formerly 1b9319b]
Former-commit-id: 7bc4ddd00a0b947590b831dc6559c6cc7ecc6a18
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #104 from linkernetworks/phstsai/pciID
19132e7 
DEV: Add pci id column
Former-commit-id: ae347c6e5676bd5c9c5889249f3c171b18692427 [formerly ae347c6e5676bd5c9c5889249f3c171b18692427 [formerly 1b9319b]]
Former-commit-id: 7bc4ddd00a0b947590b831dc6559c6cc7ecc6a18
Former-commit-id: 2d322dc
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #104 from linkernetworks/phstsai/pciID
6f5000f 
DEV: Add pci id column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WakeupTsai @codecov-io @hwchiu @John-Lin @chenyunchen