Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VX-177 johnlin/validate storage entity #105

Merged
merged 2 commits into from
Jul 16, 2018
Merged

VX-177 johnlin/validate storage entity #105

merged 2 commits into from
Jul 16, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@John-Lin John-Lin changed the title Johnlin/validate storage entity VX-177 johnlin/validate storage entity Jul 16, 2018
@codecov-io
Copy link

Codecov Report

Merging #105 into develop will increase coverage by 1.51%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #105      +/-   ##
===========================================
+ Coverage    73.22%   74.73%   +1.51%     
===========================================
  Files           35       35              
  Lines         1591     1710     +119     
===========================================
+ Hits          1165     1278     +113     
- Misses         353      356       +3     
- Partials        73       76       +3
Impacted Files Coverage Δ
src/storageprovider/nfs.go 92.04% <ø> (-0.27%) ⬇️
src/server/handler_storage.go 81.18% <0%> (-2.49%) ⬇️
src/prometheuscontroller/expression.go 87.56% <0%> (+1.61%) ⬆️
src/server/handler_volume.go 85.32% <0%> (+8.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f247bba...8be4ad9. Read the comment docs.

@hwchiu hwchiu merged commit 764af12 into develop Jul 16, 2018
@hwchiu hwchiu deleted the johnlin/validate-storage-entity branch July 16, 2018 10:22
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #105 from linkernetworks/johnlin/validate-storage-…
1d73cdc 
…entity

VX-177 johnlin/validate storage entity

Former-commit-id: a77fe9542e62283433eef828ca9f82145b99b424 [formerly 764af12]
Former-commit-id: b2aae8a389d5a79eb35a8fde8d7d383b038aac0f
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #105 from linkernetworks/johnlin/validate-storage-…
3cc9919 
…entity

VX-177 johnlin/validate storage entity

Former-commit-id: a77fe9542e62283433eef828ca9f82145b99b424 [formerly a77fe9542e62283433eef828ca9f82145b99b424 [formerly 764af12]]
Former-commit-id: b2aae8a389d5a79eb35a8fde8d7d383b038aac0f
Former-commit-id: 1d73cdc
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #105 from linkernetworks/johnlin/validate-storage-…
b049799 
…entity

VX-177 johnlin/validate storage entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@John-Lin @codecov-io @hwchiu @chenyunchen