Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multiple network interfaces #106

Merged
merged 5 commits into from
Jul 16, 2018
Merged

add multiple network interfaces #106

merged 5 commits into from
Jul 16, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 16, 2018 •
edited
Loading

Codecov Report

Merging #106 into develop will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #106      +/-   ##
===========================================
+ Coverage    73.24%   74.18%   +0.94%     
===========================================
  Files           35       35              
  Lines         1592     1681      +89     
===========================================
+ Hits          1166     1247      +81     
  Misses         353      353              
- Partials        73       81       +8
Impacted Files Coverage Δ
src/storageprovider/nfs.go 91.26% <0%> (-1.22%) ⬇️
src/volume/volume.go 92.3% <0%> (ø) ⬆️
src/kubernetes/kubectl.go 100% <0%> (ø) ⬆️
src/prometheuscontroller/expression.go 86.9% <0%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe6713...2b9b02c. Read the comment docs.

hwchiu
hwchiu approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@John-Lin John-Lin force-pushed the johnlin/vagrant-multi-interfaces branch from 02214f6 to 2b9b02c Compare July 16, 2018 09:55
hwchiu
hwchiu approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu merged commit b6d10a2 into develop Jul 16, 2018
@hwchiu hwchiu deleted the johnlin/vagrant-multi-interfaces branch July 16, 2018 10:15
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #106 from linkernetworks/johnlin/vagrant-multi-int…
fc89293 
…erfaces

add multiple network interfaces

Former-commit-id: 5967fc75f215660078c75fd0e96823f620ea26c0 [formerly b6d10a2]
Former-commit-id: d3f37100ac64af411f9c9c357d3ac8e66c82bea5
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #106 from linkernetworks/johnlin/vagrant-multi-int…
f5f0db4 
…erfaces

add multiple network interfaces

Former-commit-id: 5967fc75f215660078c75fd0e96823f620ea26c0 [formerly 5967fc75f215660078c75fd0e96823f620ea26c0 [formerly b6d10a2]]
Former-commit-id: d3f37100ac64af411f9c9c357d3ac8e66c82bea5
Former-commit-id: fc89293
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #106 from linkernetworks/johnlin/vagrant-multi-int…
7fae40f 
…erfaces

add multiple network interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@John-Lin @codecov-io @hwchiu @chenyunchen