Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use switch cases to handle mgo error #108

Merged
merged 1 commit into from
Jul 17, 2018
Merged

use switch cases to handle mgo error #108

merged 1 commit into from
Jul 17, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 17, 2018 •
edited
Loading

Codecov Report

Merging #108 into develop will decrease coverage by 0.34%.
The diff coverage is 38.7%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
- Coverage    73.05%   72.71%   -0.35%     
===========================================
  Files           35       35              
  Lines         1592     1616      +24     
===========================================
+ Hits          1163     1175      +12     
- Misses         355      379      +24     
+ Partials        74       62      -12
Impacted Files Coverage Δ
src/server/handler_volume.go 75.28% <27.27%> (-1.19%) ⬇️
src/server/handler_pod.go 75.23% <37.5%> (-1.53%) ⬇️
src/server/handler_storage.go 79.43% <40%> (-1.75%) ⬇️
src/server/handler_network.go 79.33% <45%> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 764af12...6660999. Read the comment docs.

@hwchiu hwchiu merged commit 339e9c4 into develop Jul 17, 2018
@hwchiu hwchiu deleted the johnlin/error-handling branch July 17, 2018 03:06
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #108 from linkernetworks/johnlin/error-handling
5c95ae0 
use switch cases to handle mgo error

Former-commit-id: ec37346eb38f08f502695b637fc88c41e2fe01f8 [formerly 339e9c4]
Former-commit-id: 65f60f9c06f37ad71f354b1c50a651a3df80faad
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #108 from linkernetworks/johnlin/error-handling
f8d30d5 
use switch cases to handle mgo error

Former-commit-id: ec37346eb38f08f502695b637fc88c41e2fe01f8 [formerly ec37346eb38f08f502695b637fc88c41e2fe01f8 [formerly 339e9c4]]
Former-commit-id: 65f60f9c06f37ad71f354b1c50a651a3df80faad
Former-commit-id: 5c95ae0
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #108 from linkernetworks/johnlin/error-handling
c46a248 
use switch cases to handle mgo error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@John-Lin @codecov-io @hwchiu @WakeupTsai