Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VX-186 VX-176 Validate pod entity with namespace #109

Merged
merged 2 commits into from
Jul 17, 2018
Merged

VX-186 VX-176 Validate pod entity with namespace #109

merged 2 commits into from
Jul 17, 2018

Conversation

chenyunchen
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #109 into develop will increase coverage by 1.62%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
+ Coverage    72.71%   74.33%   +1.62%     
===========================================
  Files           35       35              
  Lines         1616     1683      +67     
===========================================
+ Hits          1175     1251      +76     
+ Misses         379      362      -17     
- Partials        62       70       +8
Impacted Files Coverage Δ
src/server/handler_pod.go 77.95% <0%> (+2.71%) ⬆️
src/pod/pod.go 95.58% <100%> (+0.06%) ⬆️
src/server/handler_volume.go 80% <0%> (+4.71%) ⬆️
src/server/handler_storage.go 84.29% <0%> (+4.85%) ⬆️
src/server/handler_network.go 86.66% <0%> (+7.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339e9c4...9505678. Read the comment docs.

@chenyunchen chenyunchen changed the title VX-186 Validate pod entity with namespace VX-186 VX-176 Validate pod entity with namespace Jul 17, 2018
@John-Lin John-Lin merged commit 4503c97 into develop Jul 17, 2018
@John-Lin John-Lin deleted the alex/validatePodEntity branch July 19, 2018 03:53
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #109 from linkernetworks/alex/validatePodEntity
b60d14f 
VX-186 VX-176 Validate pod entity with namespace

Former-commit-id: 285d530b87152486b2429a923e4e319c197bd6d8 [formerly 4503c97]
Former-commit-id: fd14806e1f649dc6d8f3d64876d205a332e8dad0
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #109 from linkernetworks/alex/validatePodEntity
ef1c9af 
VX-186 VX-176 Validate pod entity with namespace

Former-commit-id: 285d530b87152486b2429a923e4e319c197bd6d8 [formerly 285d530b87152486b2429a923e4e319c197bd6d8 [formerly 4503c97]]
Former-commit-id: fd14806e1f649dc6d8f3d64876d205a332e8dad0
Former-commit-id: b60d14f
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #109 from linkernetworks/alex/validatePodEntity
48acd3c 
VX-186 VX-176 Validate pod entity with namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyunchen @codecov-io @hwchiu @John-Lin