Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more testing for src/net package #11

Merged
merged 3 commits into from
Jun 20, 2018
Merged

Add more testing for src/net package #11

merged 3 commits into from
Jun 20, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 19, 2018 •
edited
Loading

Add more testing case, including

  • net/response/*
  • net/handler.go
  • net/response.go

@hwchiu hwchiu requested a review from WakeupTsai June 19, 2018 16:31
@codecov-io
Copy link

codecov-io commented Jun 19, 2018 •
edited
Loading

Codecov Report

Merging #11 into master will increase coverage by 10.09%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #11       +/-   ##
========================================
+ Coverage    46.9%   57%   +10.09%     
========================================
  Files          11    11               
  Lines         307   307               
========================================
+ Hits          144   175       +31     
+ Misses        152   122       -30     
+ Partials       11    10        -1
Impacted Files Coverage Δ
src/net/http/responsetest/assert.go 100% <0%> (+16.66%) ⬆️
src/net/http/response.go 93.02% <0%> (+41.86%) ⬆️
src/net/http/handler.go 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345f29d...bce9426. Read the comment docs.

@John-Lin
Copy link
Contributor

change the branch to merge develop branch

@hwchiu hwchiu changed the base branch from master to develop June 20, 2018 04:09
@hwchiu hwchiu merged commit a4b499e into develop Jun 20, 2018
@hwchiu hwchiu deleted the hwchiu/add-testing branch June 20, 2018 05:41
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #11 from linkernetworks/hwchiu/add-testing
d273571 
Add more testing for src/net package

Former-commit-id: a538a72367908d4ccd65075c51150895b2671175 [formerly a4b499e]
Former-commit-id: 97a29d99102caa6f167169365c04a42459b4a035
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #11 from linkernetworks/hwchiu/add-testing
fe8c2d4 
Add more testing for src/net package

Former-commit-id: a538a72367908d4ccd65075c51150895b2671175 [formerly a538a72367908d4ccd65075c51150895b2671175 [formerly a4b499e]]
Former-commit-id: 97a29d99102caa6f167169365c04a42459b4a035
Former-commit-id: d273571
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #11 from linkernetworks/hwchiu/add-testing
23bdc11 
Add more testing for src/net package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwchiu @codecov-io @John-Lin @WakeupTsai