VX-77 VX-78 VX-79 Add service restful api and testing #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyunchen
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #114 +/- ##
===========================================
+ Coverage 72.77% 74.84% +2.06%
===========================================
Files 35 41 +6
Lines 1620 2071 +451
===========================================
+ Hits 1179 1550 +371
- Misses 379 446 +67
- Partials 62 75 +13
Continue to review full report at Codecov.
|
chenyunchen
changed the title
chenyunchen
force-pushed
the
alex/AddServiceRestfulAPI
branch
from
767b521 to
ffa846f
Compare
John-Lin
reviewed
Jul 18, 2018
src/service/service.go
Outdated
| } | ||
|
|
||
| func CheckServiceParameter(sp *serviceprovider.Container, service *entity.Service) error { | ||
| session := sp.Mongo.NewSession() |
John-Lin
reviewed
Jul 18, 2018
src/service/service.go
Outdated
| } | ||
|
|
||
| func CreateService(sp *serviceprovider.Container, service *entity.Service) error { | ||
| session := sp.Mongo.NewSession() |
|
想一下service 的物件有需要存到db嗎？ |
John-Lin
reviewed
Jul 18, 2018
src/server/handler_service_test.go
Outdated
| "github.com/linkernetworks/mongo" | ||
| "github.com/linkernetworks/vortex/src/config" | ||
| "github.com/linkernetworks/vortex/src/entity" | ||
| s "github.com/linkernetworks/vortex/src/service" |
There was a problem hiding this comment.
svc "github.com/linkernetworks/vortex/src/service"
hwchiu
approved these changes
Jul 19, 2018
John-Lin
approved these changes
Jul 19, 2018
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
VX-77 VX-78 VX-79 Add service restful api and testing Former-commit-id: 3d1c945efa325509fc94c3859405b69456e2e48e [formerly e87be4c] Former-commit-id: 51e42c7051c82a15d9ba098538c2a8502868f1ef
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
VX-77 VX-78 VX-79 Add service restful api and testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.