Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG VX191: Modify the type of default value in node struct from string to bool #117

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #117 into develop will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
- Coverage    74.36%   74.22%   -0.15%     
===========================================
  Files           37       37              
  Lines         1740     1746       +6     
===========================================
+ Hits          1294     1296       +2     
- Misses         381      383       +2     
- Partials        65       67       +2
Impacted Files Coverage Δ
src/prometheuscontroller/expression.go 84.81% <50%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34206fd...a9b284f. Read the comment docs.

@John-Lin John-Lin merged commit 010e16a into develop Jul 19, 2018
@John-Lin John-Lin deleted the phstsai/VX-191 branch July 19, 2018 03:53
John-Lin added a commit that referenced this pull request Jul 25, 2018
BUG VX191: Modify the type of default value in node struct from string to bool

Former-commit-id: 5f080e4757fc788e2b6db1d547fb657aafd88abb [formerly 010e16a]
Former-commit-id: 8b9f457259abe62b7b747edb9f8cec08ca24b0d1
John-Lin added a commit that referenced this pull request Jul 25, 2018
BUG VX191: Modify the type of default value in node struct from string to bool

Former-commit-id: 5f080e4757fc788e2b6db1d547fb657aafd88abb [formerly 5f080e4757fc788e2b6db1d547fb657aafd88abb [formerly 010e16a]]
Former-commit-id: 8b9f457259abe62b7b747edb9f8cec08ca24b0d1
Former-commit-id: a200080
John-Lin added a commit that referenced this pull request Jul 25, 2018
BUG VX191: Modify the type of default value in node struct from string to bool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants