Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the parameter order #118

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Fix the parameter order #118

merged 1 commit into from
Jul 19, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 19, 2018

No description provided.

@hwchiu hwchiu requested review from John-Lin and chenyunchen July 19, 2018 03:35
@codecov-io
Copy link

codecov-io commented Jul 19, 2018 •
edited
Loading

Codecov Report

Merging #118 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #118   +/-   ##
========================================
  Coverage    74.36%   74.36%           
========================================
  Files           37       37           
  Lines         1740     1740           
========================================
  Hits          1294     1294           
  Misses         381      381           
  Partials        65       65
Impacted Files Coverage Δ
src/pod/pod.go 96.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34206fd...3e51f8b. Read the comment docs.

@John-Lin John-Lin merged commit 083f260 into develop Jul 19, 2018
@John-Lin John-Lin deleted the hwchiu/VX-192 branch July 19, 2018 03:53
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #118 from linkernetworks/hwchiu/VX-192
275d808 
Fix the parameter order

Former-commit-id: 7a02622fe3faec40ce9a5896305fda4e26981dea [formerly 083f260]
Former-commit-id: 93eb1cbc5626f9e19f044810ef1423d186cbd781
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #118 from linkernetworks/hwchiu/VX-192
a4bce5f 
Fix the parameter order

Former-commit-id: 7a02622fe3faec40ce9a5896305fda4e26981dea [formerly 7a02622fe3faec40ce9a5896305fda4e26981dea [formerly 083f260]]
Former-commit-id: 93eb1cbc5626f9e19f044810ef1423d186cbd781
Former-commit-id: 275d808
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #118 from linkernetworks/hwchiu/VX-192
88a1a25 
Fix the parameter order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwchiu @codecov-io @John-Lin @WakeupTsai