bump network controller to v0.3.0 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WakeupTsai 你覺得要不要把 helm 裡面關於 network-controller 的tag拉出變數到外面，然後以後只要改這個變數就好? |
hwchiu
requested review from
sufuf3,
WakeupTsai and
hwchiu
and removed request for
sufuf3 and
WakeupTsai
|
@hwchiu 可以，但應該只能控制yaml裡的tag，其他地方要另外改 |
|
@WakeupTsai thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #120 +/- ##
========================================
Coverage 74.22% 74.22%
========================================
Files 37 37
Lines 1746 1746
========================================
Hits 1296 1296
Misses 383 383
Partials 67 67
Continue to review full report at Codecov.
|
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
bump network controller to v0.3.0 Former-commit-id: ea42e7cace2f40bae3d638501041f32ae57920ff [formerly d7b6858] Former-commit-id: 410f449de8fa1a9fa4498e8339f118cc7460f538
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
bump network controller to v0.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.