Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the API.md and fix the missing quota #121

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Add the API.md and fix the missing quota #121

merged 1 commit into from
Jul 19, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 19, 2018

No description provided.

@hwchiu hwchiu requested a review from chenyunchen July 19, 2018 03:56
@codecov-io
Copy link

codecov-io commented Jul 19, 2018 •
edited
Loading

Codecov Report

Merging #121 into develop will increase coverage by 1.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
+ Coverage    74.22%   75.87%   +1.65%     
===========================================
  Files           37       37              
  Lines         1746     1853     +107     
===========================================
+ Hits          1296     1406     +110     
+ Misses         383      374       -9     
- Partials        67       73       +6
Impacted Files Coverage Δ
src/prometheuscontroller/expression.go 89.51% <0%> (+4.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083f260...615f2d7. Read the comment docs.

@John-Lin John-Lin merged commit 6cdd7e7 into develop Jul 19, 2018
@hwchiu hwchiu deleted the hwchiu/VX-168 branch July 19, 2018 07:37
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #121 from linkernetworks/hwchiu/VX-168
786fdb2 
Add the API.md and fix the missing quota

Former-commit-id: 4d3ec3301c176534f78b5cd693e9c3e213af388c [formerly 6cdd7e7]
Former-commit-id: 1e04f7951cb09acc236bd4684abddbc632945750
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #121 from linkernetworks/hwchiu/VX-168
81205f2 
Add the API.md and fix the missing quota

Former-commit-id: 4d3ec3301c176534f78b5cd693e9c3e213af388c [formerly 4d3ec3301c176534f78b5cd693e9c3e213af388c [formerly 6cdd7e7]]
Former-commit-id: 1e04f7951cb09acc236bd4684abddbc632945750
Former-commit-id: 786fdb2
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #121 from linkernetworks/hwchiu/VX-168
615b24c 
Add the API.md and fix the missing quota
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwchiu @codecov-io @John-Lin