Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the vlan tag for client #123

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Support the vlan tag for client #123

merged 2 commits into from
Jul 19, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 19, 2018

Use the pointer instead of reference of vlanTag.

@hwchiu hwchiu requested review from John-Lin and chenyunchen July 19, 2018 07:06
@codecov-io
Copy link

Codecov Report

Merging #123 into develop will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
- Coverage    72.67%   72.54%   -0.13%     
===========================================
  Files           41       41              
  Lines         1943     1956      +13     
===========================================
+ Hits          1412     1419       +7     
- Misses         460      466       +6     
  Partials        71       71
Impacted Files Coverage Δ
src/pod/pod.go 96.51% <100%> (+0.06%) ⬆️
src/server/route.go 51.85% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8194b...918951f. Read the comment docs.

@John-Lin John-Lin merged commit 9264247 into develop Jul 19, 2018
@hwchiu hwchiu deleted the hwchiu/VX-187 branch July 19, 2018 07:37
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #123 from linkernetworks/hwchiu/VX-187
c326cbc 
Support the vlan tag for client

Former-commit-id: 178f3e70311d5f10a7513b72e3573b5db4d3da78 [formerly 9264247]
Former-commit-id: db36a6b8820cf89e716af15861cb91c3cb6bf4e4
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #123 from linkernetworks/hwchiu/VX-187
fc82c97 
Support the vlan tag for client

Former-commit-id: 178f3e70311d5f10a7513b72e3573b5db4d3da78 [formerly 178f3e70311d5f10a7513b72e3573b5db4d3da78 [formerly 9264247]]
Former-commit-id: db36a6b8820cf89e716af15861cb91c3cb6bf4e4
Former-commit-id: c326cbc
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #123 from linkernetworks/hwchiu/VX-187
2836777 
Support the vlan tag for client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwchiu @codecov-io @John-Lin