Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use internal IP #134

Merged
merged 1 commit into from
Jul 20, 2018
Merged

use internal IP #134

merged 1 commit into from
Jul 20, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #134 into develop will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
+ Coverage    72.71%   72.85%   +0.13%     
===========================================
  Files           41       41              
  Lines         1946     1956      +10     
===========================================
+ Hits          1415     1425      +10     
  Misses         460      460              
  Partials        71       71
Impacted Files Coverage Δ
src/networkprovider/ovs_netdev.go 62.26% <100%> (ø) ⬆️
src/networkprovider/ovs_system.go 73.68% <100%> (ø) ⬆️
src/kubernetes/nodes.go 93.33% <100%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093c94b...a8ee4b9. Read the comment docs.

@John-Lin John-Lin force-pushed the johnlin/internalIP branch from a55f043 to a8ee4b9 Compare July 20, 2018 03:34
@hwchiu hwchiu merged commit a14abab into develop Jul 20, 2018
@hwchiu hwchiu deleted the johnlin/internalIP branch July 20, 2018 05:27
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
use internal IP

Former-commit-id: a35b02ae6e52a83a022b43bad2a4b273f38f83a0 [formerly a14abab]
Former-commit-id: a92329b5e7479c55ccd41be64e235a5495d74e88
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
use internal IP

Former-commit-id: a35b02ae6e52a83a022b43bad2a4b273f38f83a0 [formerly a35b02ae6e52a83a022b43bad2a4b273f38f83a0 [formerly a14abab]]
Former-commit-id: a92329b5e7479c55ccd41be64e235a5495d74e88
Former-commit-id: a0ed2e9
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants