Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT POC for API #147

Merged
merged 5 commits into from
Jul 25, 2018
Merged

JWT POC for API #147

merged 5 commits into from
Jul 25, 2018

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Jul 20, 2018

Token-Based Auth 使用者登入驗證POC 使用JWT 驗證 API 登入驗證機制,這個PR想討論實作可行性

image

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #147 into develop will decrease coverage by 1.29%.
The diff coverage is 15.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #147     +/-   ##
==========================================
- Coverage    72.36%   71.07%   -1.3%     
==========================================
  Files           42       44      +2     
  Lines         1990     2036     +46     
==========================================
+ Hits          1440     1447      +7     
- Misses         474      513     +39     
  Partials        76       76
Impacted Files Coverage Δ
src/server/route_filter.go 0% <0%> (ø) ⬆️
src/server/route.go 49.36% <0%> (-4.8%) ⬇️
src/server/handler_authenticate.go 0% <0%> (ø)
src/server/jwt.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c205e73...39c6827. Read the comment docs.

@John-Lin
Copy link
Contributor Author

John-Lin commented Jul 24, 2018

@hwchiu @chechiachang go-restful 可以把user id 用request.SetAttribute 存起來,handler在用 reqquest.attribute 拿回來 emicklei/go-restful#71 (comment)

@John-Lin
Copy link
Contributor Author

這個 PR 會需要跟 #162 一起做

@John-Lin John-Lin force-pushed the develop branch 2 times, most recently from bb5ada7 to fddc71a Compare July 25, 2018 11:04
@hwchiu hwchiu force-pushed the johnlin/jwt-api branch from 39c6827 to b8d028c Compare July 25, 2018 11:21
@hwchiu hwchiu force-pushed the johnlin/jwt-api branch from b8d028c to d1dadab Compare July 25, 2018 11:35
@hwchiu hwchiu merged commit ce60587 into develop Jul 25, 2018
@hwchiu hwchiu deleted the johnlin/jwt-api branch July 25, 2018 11:35
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants