[Bug] VX-202: Change prometheus's service account to vortex-admin #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Lin
reviewed
Jul 23, 2018
| @@ -32,11 +32,9 @@ spec: | |||
| image: k8s.gcr.io/addon-resizer:1.7 | |||
| resources: | |||
| limits: | |||
| cpu: 100m | |||
| memory: 30Mi | |||
| cpu: 10m | |||
John-Lin
approved these changes
Jul 23, 2018
WakeupTsai
changed the title
WakeupTsai
force-pushed
the
phstsai/VX-202
branch
from
f8f546d to
2672c03
Compare
Codecov Report
@@ Coverage Diff @@
## develop #149 +/- ##
========================================
Coverage 72.18% 72.18%
========================================
Files 42 42
Lines 1995 1995
========================================
Hits 1440 1440
Misses 479 479
Partials 76 76Continue to review full report at Codecov.
|
WakeupTsai
force-pushed
the
phstsai/VX-202
branch
from
ce1c711 to
5dc8ede
Compare
John-Lin
approved these changes
Jul 24, 2018
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
[Bug] VX-202: Change prometheus's service account to vortex-admin Former-commit-id: 9da5ebdee7e333db8a447368331380276ff7291d [formerly 9bd66f4] Former-commit-id: b0e968db57ac380ca4508a5c55ea60f7b36d7dd8
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
[Bug] VX-202: Change prometheus's service account to vortex-admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.