Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Johnlin/remove influxdb #15

Merged
merged 8 commits into from
Jun 20, 2018
Merged

Johnlin/remove influxdb #15

merged 8 commits into from
Jun 20, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@John-Lin John-Lin requested review from chechiachang, WakeupTsai and hwchiu and removed request for chechiachang, WakeupTsai and hwchiu June 20, 2018 07:50
hwchiu
hwchiu approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jun 20, 2018 •
edited
Loading

Codecov Report

Merging #15 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #15   +/-   ##
=====================================
  Coverage       57%   57%           
=====================================
  Files           11    11           
  Lines          307   307           
=====================================
  Hits           175   175           
  Misses         122   122           
  Partials        10    10
Impacted Files Coverage Δ
src/server/app.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c049957...13062aa. Read the comment docs.

@John-Lin
Copy link
Contributor Author

@hwchiu 可以合併了

hwchiu
hwchiu approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu hwchiu requested a review from chenyunchen June 20, 2018 11:02
@hwchiu hwchiu merged commit b5bc830 into develop Jun 20, 2018
@hwchiu hwchiu deleted the johnlin/remove-influxdb branch June 20, 2018 16:09
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #15 from linkernetworks/johnlin/remove-influxdb
8e436ba 
Johnlin/remove influxdb

Former-commit-id: 2bfd5be406e5b9f1532bd31d25477d3d427700cd [formerly b5bc830]
Former-commit-id: c4f0258cdf518d93665c510d7ed7500cfd355086
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #15 from linkernetworks/johnlin/remove-influxdb
3a90ce7 
Johnlin/remove influxdb

Former-commit-id: 2bfd5be406e5b9f1532bd31d25477d3d427700cd [formerly 2bfd5be406e5b9f1532bd31d25477d3d427700cd [formerly b5bc830]]
Former-commit-id: c4f0258cdf518d93665c510d7ed7500cfd355086
Former-commit-id: 8e436ba
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #15 from linkernetworks/johnlin/remove-influxdb
2d92cc1 
Johnlin/remove influxdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chechiachang chechiachang Awaiting requested review from chechiachang

@WakeupTsai WakeupTsai Awaiting requested review from WakeupTsai

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-Lin @codecov-io @hwchiu