Fix golint for types & functions need comment #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sufuf3
force-pushed
the
sufuf3/fix-goreport
branch
from
18a2de4 to
180b050
Compare
sufuf3
force-pushed
the
sufuf3/fix-goreport
branch
from
180b050 to
087f222
Compare
sufuf3
changed the title
|
還有變數名稱的問題，但因為可能會牽涉使用這些變數的 code ，所以這隻 PR 暫時不修改。 $ golint src/*
src/networkcontroller/network_controller.go:13:7: don't use ALL_CAPS in Go names; use CamelCase
src/networkprovider/ovs_netdev_test.go:24:7: don't use ALL_CAPS in Go names; use CamelCase
src/networkprovider/ovs_system_test.go:25:7: don't use ALL_CAPS in Go names; use CamelCase
src/prometheusprovider/promehteus.go:11:2: struct field Url should be URL
src/prometheusprovider/promehteus.go:16:2: struct field Url should be URL
src/server/response.go:20:2: struct field SignInUrl should be SignInURL |
Codecov Report
@@ Coverage Diff @@
## develop #153 +/- ##
========================================
Coverage 72.18% 72.18%
========================================
Files 42 42
Lines 1995 1995
========================================
Hits 1440 1440
Misses 479 479
Partials 76 76
Continue to review full report at Codecov.
|
|
我來改這個 |
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
Fix golint for types & functions need comment Former-commit-id: 69ef6b2c6b3af55db7fb2634781e0b74a004edfe [formerly 55fb83b] Former-commit-id: 8a268d0dee2c1a48873171f61d746c6dca1fb39f
John-Lin
added a commit
that referenced
this pull request
Jul 25, 2018
Fix golint for types & functions need comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golint is 49%, now.
This PR is for fixing golint.