Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golint #156

Merged
merged 3 commits into from
Jul 24, 2018
Merged

fix golint #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
578446c
fix golint
John-Lin Jul 24, 2018
8e6d383
fix test
John-Lin Jul 24, 2018
a05a1b5
fix
John-Lin Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/prometheusprovider/promehteus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ import (

// PrometheusConfig is the structure for Prometheus Config
type PrometheusConfig struct {
Url string `json:"url"`
URL string `json:"url"`
}

// Service is the structure for Service
type Service struct {
Url string
URL string
API prometheus.API
}

Expand All @@ -33,7 +33,7 @@ func New(url string) *Service {
newAPI := prometheus.NewAPI(client)

return &Service{
Url: url,
URL: url,
API: newAPI,
}
}
2 changes: 1 addition & 1 deletion src/server/response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type SignInResponse struct {
Error bool `json:"error"`
AuthRequired bool `json:"authenRequired,omitempty"`
Message string `json:"message"`
SignInUrl string `json:"signInUrl,omitempty"`
SignInURL string `json:"signInURL,omitempty"`
Session SessionResponse `json:"session,omitempty"`
}

Expand Down
8 changes: 4 additions & 4 deletions src/serviceprovider/serviceprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ func New(cf config.Config) *Container {
logger.Infof("Connecting to mongodb: %s", cf.Mongo.Url)
mongo := mongo.New(cf.Mongo.Url)

logger.Infof("Connecting to prometheus: %s", cf.Prometheus.Url)
prometheus := prometheusprovider.New(cf.Prometheus.Url)
logger.Infof("Connecting to prometheus: %s", cf.Prometheus.URL)
prometheus := prometheusprovider.New(cf.Prometheus.URL)

kubeconfig := filepath.Join(os.Getenv("HOME"), ".kube", "config")
k8s, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
Expand Down Expand Up @@ -90,8 +90,8 @@ func NewForTesting(cf config.Config) *Container {
logger.Infof("Connecting to mongodb: %s", cf.Mongo.Url)
mongo := mongo.New(cf.Mongo.Url)

logger.Infof("Connecting to prometheus: %s", cf.Prometheus.Url)
prometheus := prometheusprovider.New(cf.Prometheus.Url)
logger.Infof("Connecting to prometheus: %s", cf.Prometheus.URL)
prometheus := prometheusprovider.New(cf.Prometheus.URL)

clientset := fakeclientset.NewSimpleClientset()

Expand Down