Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX Phstsai/dockerfile govendor #16

Merged
merged 2 commits into from
Jun 20, 2018
Merged

BUGFIX Phstsai/dockerfile govendor #16

merged 2 commits into from
Jun 20, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@WakeupTsai WakeupTsai requested review from hwchiu and John-Lin June 20, 2018 08:57
hwchiu
hwchiu approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jun 20, 2018 •
edited
Loading

Codecov Report

Merging #16 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #16   +/-   ##
=====================================
  Coverage       57%   57%           
=====================================
  Files           11    11           
  Lines          307   307           
=====================================
  Hits           175   175           
  Misses         122   122           
  Partials        10    10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c049957...2302d91. Read the comment docs.

@John-Lin John-Lin merged commit e71e80f into develop Jun 20, 2018
@hwchiu hwchiu deleted the phstsai/dockerfile-govendor branch June 20, 2018 09:14
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #16 from linkernetworks/phstsai/dockerfile-govendor
950c897 
BUGFIX Phstsai/dockerfile govendor

Former-commit-id: e06d53fc5ee8a93cba6c5788fbb850c970f89fd6 [formerly e71e80f]
Former-commit-id: 47c2896f863162294c3aa2e99c59d1494e7313d5
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #16 from linkernetworks/phstsai/dockerfile-govendor
501373b 
BUGFIX Phstsai/dockerfile govendor

Former-commit-id: e06d53fc5ee8a93cba6c5788fbb850c970f89fd6 [formerly e06d53fc5ee8a93cba6c5788fbb850c970f89fd6 [formerly e71e80f]]
Former-commit-id: 47c2896f863162294c3aa2e99c59d1494e7313d5
Former-commit-id: 950c897
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #16 from linkernetworks/phstsai/dockerfile-govendor
147e587 
BUGFIX Phstsai/dockerfile govendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WakeupTsai @codecov-io @hwchiu @John-Lin