Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] VX-212: List all the detail of the resource instead of just name #166

Merged
merged 2 commits into from
Jul 25, 2018
Merged

[Task] VX-212: List all the detail of the resource instead of just name #166

merged 2 commits into from
Jul 25, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 25, 2018 •
edited
Loading

Codecov Report

Merging #166 into develop will decrease coverage by 1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
- Coverage    72.36%   71.35%   -1.01%     
===========================================
  Files           42       42              
  Lines         1990     2018      +28     
===========================================
  Hits          1440     1440              
- Misses         474      502      +28     
  Partials        76       76
Impacted Files Coverage Δ
src/server/handler_prometheus.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c205e73...58d3221. Read the comment docs.

@John-Lin John-Lin merged commit 8e6d031 into develop Jul 25, 2018
@John-Lin John-Lin deleted the phstsai/VX-212 branch July 25, 2018 04:00
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #166 from linkernetworks/phstsai/VX-212
552c033 
[Task] VX-212: List all the detail of the resource instead of just name

Former-commit-id: ef7503699941033651126e1735ad14ee397bffbb [formerly 8e6d031]
Former-commit-id: 3cc0c0600f135a96a2afb37905bc90f2d4d70dc1
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #166 from linkernetworks/phstsai/VX-212
aa97903 
[Task] VX-212: List all the detail of the resource instead of just name

Former-commit-id: ef7503699941033651126e1735ad14ee397bffbb [formerly ef7503699941033651126e1735ad14ee397bffbb [formerly 8e6d031]]
Former-commit-id: 3cc0c0600f135a96a2afb37905bc90f2d4d70dc1
Former-commit-id: 552c033
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #166 from linkernetworks/phstsai/VX-212
0d068a5 
[Task] VX-212: List all the detail of the resource instead of just name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

@hwchiu hwchiu Awaiting requested review from hwchiu

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WakeupTsai @codecov-io @John-Lin @chenyunchen