Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] VX-214: Unit test for prometheus handler #170

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #170 into develop will increase coverage by 6.45%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    71.55%   78.01%   +6.45%     
===========================================
  Files           42       41       -1     
  Lines         2011     2001      -10     
===========================================
+ Hits          1439     1561     +122     
+ Misses         496      332     -164     
- Partials        76      108      +32
Impacted Files Coverage Δ
src/net/http/response.go 93.02% <ø> (ø) ⬆️
src/server/route_filter.go 0% <ø> (ø) ⬆️
src/prometheuscontroller/expression.go 85.95% <ø> (ø) ⬆️
src/server/handler_pod.go 73.14% <100%> (ø) ⬆️
src/server/handler_service.go 75.23% <100%> (ø) ⬆️
src/server/handler_storage.go 82.24% <100%> (ø) ⬆️
src/server/handler_network.go 73.61% <100%> (ø) ⬆️
src/server/handler_volume.go 75.28% <100%> (ø) ⬆️
src/server/handler_version.go 100% <100%> (+100%) ⬆️
src/server/route.go 81.94% <0%> (+27.77%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e355d85...cf0fcec. Read the comment docs.

@hwchiu hwchiu merged commit 1e3669b into develop Jul 25, 2018
@hwchiu hwchiu deleted the phstsai/VX-214 branch July 25, 2018 07:28
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
[Task] VX-214: Unit test for prometheus handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants