Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] VX-214: Improve unit test for query situation #172

Merged
merged 1 commit into from
Jul 25, 2018
Merged

[Task] VX-214: Improve unit test for query situation #172

merged 1 commit into from
Jul 25, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 25, 2018 •
edited
Loading

Codecov Report

Merging #172 into develop will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #172      +/-   ##
==========================================
+ Coverage    77.95%   79.2%   +1.24%     
==========================================
  Files           41      41              
  Lines         2005    2005              
==========================================
+ Hits          1563    1588      +25     
+ Misses         333     324       -9     
+ Partials       109      93      -16
Impacted Files Coverage Δ
src/server/handler_prometheus.go 71.59% <0%> (+14.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b2372...d9486c6. Read the comment docs.

@John-Lin John-Lin merged commit bd21f12 into develop Jul 25, 2018
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #172 from linkernetworks/phstsai/VX-214
bb5ada7 
[Task] VX-214: Improve unit test for query situation

Former-commit-id: 1f1c84e690e0411290914d967e1db5229d6f7b90 [formerly bd21f12]
Former-commit-id: 89b4b0be52641a2ee34aa15ad473740b73f79d18
@hwchiu hwchiu deleted the phstsai/VX-214 branch July 25, 2018 10:54
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #172 from linkernetworks/phstsai/VX-214
fddc71a 
[Task] VX-214: Improve unit test for query situation

Former-commit-id: 1f1c84e690e0411290914d967e1db5229d6f7b90 [formerly 1f1c84e690e0411290914d967e1db5229d6f7b90 [formerly bd21f12]]
Former-commit-id: 89b4b0be52641a2ee34aa15ad473740b73f79d18
Former-commit-id: bb5ada7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Lin John-Lin John-Lin approved these changes

@hwchiu hwchiu Awaiting requested review from hwchiu

@chenyunchen chenyunchen Awaiting requested review from chenyunchen

@sufuf3 sufuf3 Awaiting requested review from sufuf3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WakeupTsai @codecov-io @John-Lin