Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] VX-217 fix error handling for k8s #177

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@John-Lin John-Lin force-pushed the johnlin/fix-k8s-services-error branch from c79e24f to 7eb1f85 Compare July 25, 2018 16:36
@codecov-io
Copy link

Codecov Report

Merging #177 into develop will decrease coverage by 0.16%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
- Coverage    77.71%   77.55%   -0.17%     
===========================================
  Files           45       45              
  Lines         2217     2223       +6     
===========================================
+ Hits          1723     1724       +1     
- Misses         394      398       +4     
- Partials       100      101       +1
Impacted Files Coverage Δ
src/server/handler_service.go 72.07% <25%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f7916...7eb1f85. Read the comment docs.

@John-Lin John-Lin merged commit 9e1aa2f into develop Jul 26, 2018
@John-Lin John-Lin deleted the johnlin/fix-k8s-services-error branch July 27, 2018 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants