Add k8s get node by name and list nodes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix Travis |
|
|
chenyunchen
force-pushed
the
alex/AddK8sGetNode
branch
from
371abbf to
02a6ed8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #18 +/- ##
===========================================
+ Coverage 57.18% 57.91% +0.72%
===========================================
Files 11 12 +1
Lines 306 316 +10
===========================================
+ Hits 175 183 +8
- Misses 121 122 +1
- Partials 10 11 +1
Continue to review full report at Codecov.
|
chenyunchen
force-pushed
the
alex/AddK8sGetNode
branch
from
98339c9 to
d801b7f
Compare
John-Lin
suggested changes
Jun 20, 2018
| @@ -2,6 +2,24 @@ | |||
| "comment": "", | |||
| "ignore": "test", | |||
| "package": [ | |||
| { | |||
| "path": "appengine", | |||
| "revision": "" | ||
| }, | ||
| { | ||
| "path": "appengine_internal", |
| "revision": "" | ||
| }, | ||
| { | ||
| "path": "appengine_internal/base", |
John-Lin
suggested changes
Jun 20, 2018
src/kubernetes/nodes.go
Outdated
| package kubernetes | ||
|
|
||
| import ( | ||
| v1 "k8s.io/api/core/v1" |
There was a problem hiding this comment.
use corev1 to distinguish metav1
chenyunchen
force-pushed
the
alex/AddK8sGetNode
branch
2 times, most recently
from
560580c to
7af24e1
Compare
John-Lin
approved these changes
Jun 21, 2018
chenyunchen
force-pushed
the
alex/AddK8sGetNode
branch
2 times, most recently
from
30c92de to
e6276eb
Compare
chenyunchen
force-pushed
the
alex/AddK8sGetNode
branch
from
e6276eb to
7429dc8
Compare
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Add k8s get node by name and list nodes Former-commit-id: 8d78279f58c0e36f13a6d2786f305ebaa15289fe [formerly 8e1bb4e] Former-commit-id: 8273163606cb4e2807d6cdf263c6f3dd52fd4d2a
John-Lin
pushed a commit
that referenced
this pull request
Jul 25, 2018
Add k8s get node by name and list nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.