[Task] VX-222 Johnlin/user jwt auth #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
approved these changes
Jul 26, 2018
src/server/handler_user_test.go
Outdated
| defer suite.session.Remove(entity.UserCollectionName, "email", u.Email) | ||
| err := suite.session.Insert(entity.UserCollectionName, &u) | ||
| suite.NoError(err) | ||
| fmt.Printf("XXXXX Insert %s\n", u.LoginCredential.Email) |
sufuf3
reviewed
Jul 26, 2018
src/server/core/authenticate.go
Outdated
| SecretKey = "linkernetworks" | ||
| ) | ||
|
|
||
| func Authenticate(session *mongo.Session, credential entity.LoginCredential) (entity.User, bool, error) { |
There was a problem hiding this comment.
Let's add comment to fit golint?
What do you think?
Thank you.
Codecov Report
@@ Coverage Diff @@
## develop #183 +/- ##
===========================================
- Coverage 78.71% 78.51% -0.21%
===========================================
Files 45 48 +3
Lines 2218 2299 +81
===========================================
+ Hits 1746 1805 +59
- Misses 365 379 +14
- Partials 107 115 +8
Continue to review full report at Codecov.
|
John-Lin
force-pushed
the
johnlin/user-jwt-auth
branch
from
2d6c3a6 to
5c43647
Compare
hwchiu
approved these changes
Jul 26, 2018
John-Lin
force-pushed
the
johnlin/user-jwt-auth
branch
4 times, most recently
from
683d8ca to
c5030f4
Compare
hwchiu
approved these changes
Jul 30, 2018
John-Lin
force-pushed
the
johnlin/user-jwt-auth
branch
from
c5030f4 to
2ec1fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.