[Task] Support hostnetwork option when creating Pod #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #186 +/- ##
===========================================
- Coverage 78.95% 78.92% -0.04%
===========================================
Files 45 45
Lines 2229 2240 +11
===========================================
+ Hits 1760 1768 +8
- Misses 364 365 +1
- Partials 105 107 +2
Continue to review full report at Codecov.
|
zyfdegh
reviewed
Jul 27, 2018
src/entity/pod.go
Outdated
| @@ -52,7 +52,8 @@ type Pod struct { | |||
| Volumes []PodVolume `bson:"volumes,omitempty" json:"volumes" validate:"required,dive,required"` | |||
| Networks []PodNetwork `bson:"networks,omitempty" json:"networks" validate:"required,dive,required"` | |||
| RestartPolicy string `bson:"restartPolicy" json:"restartPolicy" validate:"required,eq=Always|eq=OnFailure|eq=Never` | |||
| Capability bool `bson:"capability" json:"Capability" validate:"required"` | |||
| Capability bool `bson:"capability" json:"Capability" validate:"-"` | |||
There was a problem hiding this comment.
Please use underscore for json:"capability"
John-Lin
approved these changes
Jul 27, 2018
chenyunchen
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some case, the Pod wants to use the hostNetwork rather than any bridge-like network.