Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] VX-225: Refactor the prometheus #190

Merged
merged 7 commits into from
Jul 30, 2018
Merged

[Task] VX-225: Refactor the prometheus #190

merged 7 commits into from
Jul 30, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #190 into develop will increase coverage by 0.47%.
The diff coverage is 87.4%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
+ Coverage    78.95%   79.43%   +0.47%     
===========================================
  Files           45       46       +1     
  Lines         2229     2334     +105     
===========================================
+ Hits          1760     1854      +94     
- Misses         364      374      +10     
- Partials       105      106       +1
Impacted Files Coverage Δ
src/prometheuscontroller/expression.go 58.33% <58.33%> (-26.95%) ⬇️
src/prometheuscontroller/query.go 88.88% <81.81%> (-5.4%) ⬇️
src/server/handler_prometheus.go 66.43% <87.5%> (-5.17%) ⬇️
src/prometheuscontroller/controller.go 90.02% <90.02%> (ø)
src/pod/pod.go 93.26% <0%> (-0.63%) ⬇️
src/net/http/handler.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f590fff...825d23e. Read the comment docs.

@hwchiu hwchiu merged commit ea8ae45 into develop Jul 30, 2018
@hwchiu hwchiu deleted the phstsai/VX-225 branch July 30, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants