Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] VX-220: Query historical data from prometheus. #198

Merged
merged 6 commits into from
Jul 31, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #198 into develop will increase coverage by 0.45%.
The diff coverage is 86.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
+ Coverage    78.84%   79.29%   +0.45%     
===========================================
  Files           49       49              
  Lines         2387     2454      +67     
===========================================
+ Hits          1882     1946      +64     
+ Misses         389      386       -3     
- Partials       116      122       +6
Impacted Files Coverage Δ
src/prometheuscontroller/expression.go 94.87% <100%> (+36.53%) ⬆️
src/prometheuscontroller/query.go 88.88% <100%> (ø) ⬆️
src/prometheuscontroller/controller.go 88.04% <85.84%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb9b0a...37cf022. Read the comment docs.

@WakeupTsai WakeupTsai changed the title [WIP][Task] VX-220: Query historical data from prometheus. [Task] VX-220: Query historical data from prometheus. Jul 30, 2018
@John-Lin
Copy link
Contributor

Conflict

@John-Lin John-Lin merged commit bd46690 into develop Jul 31, 2018
@John-Lin John-Lin deleted the phstsai/VX-220 branch August 1, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants