Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Change the timeout to 10 seconds #199

Merged
merged 1 commit into from
Jul 27, 2018
Merged

[Bug] Change the timeout to 10 seconds #199

merged 1 commit into from
Jul 27, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jul 27, 2018

We will meet the random testing fail in the travis CI environment.
The message is context deadline exceeded and We thinks it's caused by the client didn't get the response from the grpc Server in a timeout value.
The current value is one second and we try to change to ten seconds to validate our guess.

@codecov-io
Copy link

Codecov Report

Merging #199 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #199   +/-   ##
========================================
  Coverage    78.71%   78.71%           
========================================
  Files           45       45           
  Lines         2218     2218           
========================================
  Hits          1746     1746           
  Misses         365      365           
  Partials       107      107
Impacted Files Coverage Δ
src/networkcontroller/network_controller.go 82.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b274add...b13a537. Read the comment docs.

@John-Lin John-Lin merged commit cd3d82d into develop Jul 27, 2018
@John-Lin John-Lin deleted the hwchiu/vx-223 branch July 27, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants