Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the flag prase problem and remove unused logs #20

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix the flag prase problem and remove unused logs #20

merged 1 commit into from
Jun 21, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 21, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #20 into develop will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #20      +/-   ##
===========================================
+ Coverage       57%   57.18%   +0.18%     
===========================================
  Files           11       11              
  Lines          307      306       -1     
===========================================
  Hits           175      175              
+ Misses         122      121       -1     
  Partials        10       10
Impacted Files Coverage Δ
src/server/app.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bc830...86afedc. Read the comment docs.

@WakeupTsai WakeupTsai requested review from WakeupTsai and removed request for WakeupTsai June 21, 2018 02:39
sufuf3
sufuf3 approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@sufuf3 sufuf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hwchiu hwchiu merged commit 12a924d into develop Jun 21, 2018
@hwchiu hwchiu deleted the hwchiu/config-parser branch June 21, 2018 03:21
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #20 from linkernetworks/hwchiu/config-parser
13ec84d 
Fix the flag prase problem and remove unused logs

Former-commit-id: 1f621db65111f0f431e199d7133483c7dbd6fa47 [formerly 12a924d]
Former-commit-id: 61c60e186c06d93de689439b5bdde5e52c0795ee
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #20 from linkernetworks/hwchiu/config-parser
5450e27 
Fix the flag prase problem and remove unused logs

Former-commit-id: 1f621db65111f0f431e199d7133483c7dbd6fa47 [formerly 1f621db65111f0f431e199d7133483c7dbd6fa47 [formerly 12a924d]]
Former-commit-id: 61c60e186c06d93de689439b5bdde5e52c0795ee
Former-commit-id: 13ec84d
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Merge pull request #20 from linkernetworks/hwchiu/config-parser
adf70aa 
Fix the flag prase problem and remove unused logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyunchen chenyunchen chenyunchen approved these changes

@sufuf3 sufuf3 sufuf3 approved these changes

@WakeupTsai WakeupTsai WakeupTsai approved these changes

@John-Lin John-Lin Awaiting requested review from John-Lin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwchiu @codecov-io @chenyunchen @sufuf3 @WakeupTsai