[Task] VX-233 johnlin/resource createdby

[John-Lin]

No description provided.

[codecov-io]

Codecov Report

Merging #204 into develop will increase coverage by <.01%.
The diff coverage is 67.81%.

@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
+ Coverage    78.57%   78.57%   +<.01%     
===========================================
  Files           59       60       +1     
  Lines         3300     3361      +61     
===========================================
+ Hits          2593     2641      +48     
- Misses         540      547       +7     
- Partials       167      173       +6

Impacted Files	Coverage Δ
src/networkprovider/ovs_system.go	77.77% <ø> (+4.09%)	⬆️
src/networkprovider/ovs_netdev.go	64.7% <ø> (+2.44%)	⬆️
src/server/backend/user.go	0% <0%> (ø)
src/server/backend/authenticate.go	83.33% <100%> (ø)	⬆️
src/server/backend/jwt.go	100% <100%> (ø)	⬆️
src/server/route.go	84.67% <100%> (+0.51%)	⬆️
src/server/handler_volume.go	68.68% <62.5%> (-0.55%)	⬇️
src/server/handler_network.go	71.33% <66.66%> (-0.29%)	⬇️
src/server/handler_service.go	70.94% <66.66%> (-0.36%)	⬇️
src/server/handler_pod.go	69.16% <66.66%> (-0.21%)	⬇️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf50cfa...e2dbc66. Read the comment docs.

[WakeupTsai]

一般是不是都存ID之類的，需要存到整個entity嗎？

[John-Lin]

需要，這樣比較有效率 不用再多打一次 user api

[hwchiu]

這樣如果user可以修改任何欄位的話，就會造成資訊不對等

[hwchiu]

同時若有user被刪除，你從這邊不能知道他被刪除

[hwchiu]

我們大部分操作都不會很大量的需求所以這邊的mongo lookuuup 應該沒太大的效能問題

[John-Lin]

user 不能修改id. 這個有跟前端討論過，主要是前端 query 的方式，多打一次user前端邏輯變得複雜

[WakeupTsai]

空一格是故意的嗎？

[John-Lin]

這是他的header規則

Authorization: Bearer <token>

[WakeupTsai]

沒有處理v!=0時的db drop

[John-Lin]

我後來想一下 failedDropTestDatabase 都會跑到即使是 v!=0

[hwchiu]

真怪，按照 short circult最佳化，應該前面false, 後面就不會跑了?

另外，如果testing都如預料以及預期，成功跑完不需要清空 mongo.因為 testing本身就要清除乾淨

[John-Lin]

using $lookup to aggregate data

for example

db.users.insert({"_id":1,"username":"john"})
db.users.insert({"_id":2,"username":"john2"})
db.users.insert({"_id":3,"username":"yoyo"})
db.users.insert({"_id":4,"username":"yoyo2"})


db.networks.insert({"_id":1,"uid":3,"networkName":"yoyo-net"})
db.networks.insert({"_id":2,"uid":2,"networkName":"john-net2"})
db.networks.insert({"_id":3,"uid":1,"networkName":"john-net"})
db.networks.insert({"_id":4,"uid":4,"networkName":"yoyo-net2"})


db.networks.aggregate([
    {
      $lookup:
        {
          from: "users",
          localField: "uid",
          foreignField: "_id",
          as: "users_docs"
        }
   }
])


db.networks.aggregate([
    {
      $lookup:
        {
          from: "users",
          localField: "uid",
          foreignField: "_id",
          as: "users_docs"
        }
   },
   { $match : { _id : 3 } }
])

[John-Lin]

還剩下 deployment, app, namespace, storage, user 尚未做auth