[TASK] Support the PodNetworkType and NodeAffinity filed in the pod entity. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2018 09:27
Codecov Report
@@ Coverage Diff @@
## develop #205 +/- ##
===========================================
+ Coverage 79.2% 81.66% +2.45%
===========================================
Files 49 49
Lines 2462 2825 +363
===========================================
+ Hits 1950 2307 +357
- Misses 388 390 +2
- Partials 124 128 +4
Continue to review full report at Codecov.
|
added 2 commits
July 31, 2018 03:08
John-Lin
changed the title
John-Lin
reviewed
Jul 31, 2018
src/pod/pod.go
Outdated
| } | ||
| case entity.PodClusterNetwork: | ||
| //For cluster network, we won't set the nodeAffinity and any netwokr options. |
hwchiu
changed the title
hwchiu
force-pushed
the
hwchiu/VX-231
branch
2 times, most recently
from
22f901f to
4dd40c9
Compare
WakeupTsai
reviewed
Aug 1, 2018
src/pod/pod.go
Outdated
| @@ -231,16 +231,26 @@ func CreatePod(sp *serviceprovider.Container, pod *entity.Pod) error { | |||
| return err | |||
| } | |||
|
|
|||
| nodeNames := []string{} | |||
| nodeNames := pod.NodeAffinity | |||
There was a problem hiding this comment.
要不要把nodeNames改成nodeAffinity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pod entity, we use the PodNetworkType to choose what kind of the network the Pod use and use the
nodeAffinityto indicate which nodes it wants to run.