Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Modify the setting of vortex server in yamls #22

Merged
merged 1 commit into from
Jun 21, 2018
Merged

BUGFIX: Modify the setting of vortex server in yamls #22

merged 1 commit into from
Jun 21, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 21, 2018 •
edited
Loading

Codecov Report

Merging #22 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #22   +/-   ##
========================================
  Coverage    57.18%   57.18%           
========================================
  Files           11       11           
  Lines          306      306           
========================================
  Hits           175      175           
  Misses         121      121           
  Partials        10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a924d...64b6465. Read the comment docs.

hwchiu
hwchiu approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@John-Lin John-Lin merged commit 79a10f0 into develop Jun 21, 2018
@John-Lin John-Lin deleted the phstsai/modify-vortex-yaml branch June 22, 2018 02:18
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #22 from linkernetworks/phstsai/modify-vortex-yaml
e72ee31 
BUGFIX: Modify the setting of vortex server in yamls
Former-commit-id: 53cd11e5ace79d97785ca7e9b582f8ff8e5e9b72 [formerly 79a10f0]
Former-commit-id: e6e1a9bf726a79ed61ff85a7a490c8dc06e9ad3f
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #22 from linkernetworks/phstsai/modify-vortex-yaml
cb2eb06 
BUGFIX: Modify the setting of vortex server in yamls
Former-commit-id: 53cd11e5ace79d97785ca7e9b582f8ff8e5e9b72 [formerly 53cd11e5ace79d97785ca7e9b582f8ff8e5e9b72 [formerly 79a10f0]]
Former-commit-id: e6e1a9bf726a79ed61ff85a7a490c8dc06e9ad3f
Former-commit-id: e72ee31
John-Lin added a commit that referenced this pull request Jul 25, 2018
@John-Lin
Merge pull request #22 from linkernetworks/phstsai/modify-vortex-yaml
bd616d9 
BUGFIX: Modify the setting of vortex server in yamls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@John-Lin John-Lin John-Lin approved these changes

@sufuf3 sufuf3 Awaiting requested review from sufuf3

@chechiachang chechiachang Awaiting requested review from chechiachang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WakeupTsai @codecov-io @hwchiu @John-Lin