Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] VX-254: Pull resource setting out from yaml #228

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #228 into develop will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #228      +/-   ##
==========================================
- Coverage    78.58%   78.5%   -0.09%     
==========================================
  Files           50      50              
  Lines         2484    2484              
==========================================
- Hits          1952    1950       -2     
- Misses         410     412       +2     
  Partials       122     122
Impacted Files Coverage Δ
src/prometheuscontroller/controller.go 86.8% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e682000...22a0837. Read the comment docs.

@John-Lin
Copy link
Contributor

John-Lin commented Aug 8, 2018

@WakeupTsai 有測試部署過嗎?可能需要 -o yaml 看一下他的qos class是不是Burstable

@WakeupTsai
Copy link
Contributor Author

image

@John-Lin John-Lin merged commit fa87098 into develop Aug 8, 2018
@John-Lin John-Lin deleted the phstsai/VX-254 branch August 8, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants