Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] remove required #231

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Aug 8, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #231 into develop will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #231      +/-   ##
===========================================
+ Coverage    78.58%   78.63%   +0.05%     
===========================================
  Files           50       50              
  Lines         2484     2523      +39     
===========================================
+ Hits          1952     1984      +32     
- Misses         410      417       +7     
  Partials       122      122
Impacted Files Coverage Δ
src/prometheuscontroller/controller.go 86.83% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7adf1...8515caa. Read the comment docs.

@John-Lin John-Lin merged commit 620296b into develop Aug 8, 2018
@John-Lin John-Lin deleted the johnlin/remove-route-gw-required branch August 8, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants