[Bug] handle k8s error #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
reviewed
Aug 9, 2018
| @@ -104,7 +104,7 @@ func (suite *PodTestSuite) TestCreatePod() { | |||
| httpRequest.Header.Add("Content-Type", "application/json") | |||
| httpWriter = httptest.NewRecorder() | |||
| suite.wc.Dispatch(httpWriter, httpRequest) | |||
| assertResponseCode(suite.T(), http.StatusInternalServerError, httpWriter) | |||
| assertResponseCode(suite.T(), http.StatusConflict, httpWriter) | |||
There was a problem hiding this comment.
Create fail since the body is empty. so the return is InternalServcer
There was a problem hiding this comment.
應該不是這個問題，因為他會創同一個podname預期是要conflict
Codecov Report
@@ Coverage Diff @@
## develop #239 +/- ##
===========================================
- Coverage 78.38% 77.94% -0.44%
===========================================
Files 50 50
Lines 2484 2498 +14
===========================================
Hits 1947 1947
- Misses 415 424 +9
- Partials 122 127 +5
Continue to review full report at Codecov.
|
hwchiu
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.