Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] VX-261: Show uid when get the pod in prometheus #241

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #241 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #241      +/-   ##
===========================================
+ Coverage    78.38%   78.39%   +<.01%     
===========================================
  Files           50       50              
  Lines         2484     2485       +1     
===========================================
+ Hits          1947     1948       +1     
  Misses         415      415              
  Partials       122      122
Impacted Files Coverage Δ
src/prometheuscontroller/controller.go 86.83% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2aca9e...c257607. Read the comment docs.

@John-Lin
Copy link
Contributor

我們這個晚一點合併?因為我是傾向使用官方image我們不維護image

@hwchiu
Copy link
Contributor

hwchiu commented Aug 13, 2018

官方若不接受,我們就自己維護囉,這邊給個一兩天看看官方要不要收

@WakeupTsai
Copy link
Contributor Author

WakeupTsai commented Aug 13, 2018

@John-Lin @hwchiu 不知道官方會不會收,如果pod顯示uid的話,其他人的uid照理來說也要一併寫一寫!?
我要現在就發PR給官方repo,還是補完deployment, service, statefulest.... 的uid再說?

@John-Lin
Copy link
Contributor

@WakeupTsai 你可以先發一個 Issue問他說,想要看到 pod的UUID 可不可以發PR進去

@hwchiu
Copy link
Contributor

hwchiu commented Aug 22, 2018

conflicts

@John-Lin
Copy link
Contributor

John-Lin commented Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants