Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] VX-268: Use exported_node to query metric fome node-exporter #249

Merged
merged 2 commits into from
Aug 16, 2018

Conversation

WakeupTsai
Copy link
Contributor

No description provided.

@John-Lin
Copy link
Contributor

如果名稱會混淆可能考慮要記一下文件 @WakeupTsai

@codecov-io
Copy link

codecov-io commented Aug 16, 2018

Codecov Report

Merging #249 into develop will decrease coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #249      +/-   ##
===========================================
- Coverage    78.29%   78.26%   -0.03%     
===========================================
  Files           53       53              
  Lines         2649     2655       +6     
===========================================
+ Hits          2074     2078       +4     
- Misses         437      438       +1     
- Partials       138      139       +1
Impacted Files Coverage Δ
src/prometheuscontroller/controller.go 86.55% <76.92%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b968baf...4d86dc9. Read the comment docs.

@John-Lin John-Lin merged commit 481d87f into develop Aug 16, 2018
@John-Lin John-Lin deleted the phstsai/VX-268 branch August 17, 2018 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants