Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s clientset to service provider #25

Merged
merged 3 commits into from
Jun 22, 2018
Merged

Conversation

chenyunchen
Copy link
Contributor

No description provided.

Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenyunchen chenyunchen force-pushed the alex/serviceproviderk8s branch 3 times, most recently from bbde2bf to 2686ec8 Compare June 22, 2018 05:44
@chenyunchen chenyunchen force-pushed the alex/serviceproviderk8s branch from 2686ec8 to 9df34e0 Compare June 22, 2018 05:47
@codecov-io
Copy link

Codecov Report

Merging #25 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #25   +/-   ##
========================================
  Coverage    57.91%   57.91%           
========================================
  Files           12       12           
  Lines          316      316           
========================================
  Hits           183      183           
  Misses         122      122           
  Partials        11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b0bfe...9df34e0. Read the comment docs.

@hwchiu hwchiu merged commit b20e7fd into develop Jun 22, 2018
@hwchiu hwchiu deleted the alex/serviceproviderk8s branch June 22, 2018 06:13
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Add k8s clientset to service provider

Former-commit-id: 7798003f62afcb1ddbe5576bbc0d22d57412f800 [formerly b20e7fd]
Former-commit-id: f59670d413c45d98afa71d087c4159633ef678f6
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Add k8s clientset to service provider

Former-commit-id: 7798003f62afcb1ddbe5576bbc0d22d57412f800 [formerly 7798003f62afcb1ddbe5576bbc0d22d57412f800 [formerly b20e7fd]]
Former-commit-id: f59670d413c45d98afa71d087c4159633ef678f6
Former-commit-id: b17c1cd
John-Lin pushed a commit that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants