[Task] Support the deployment when creating resources. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #257 +/- ##
===========================================
+ Coverage 78.27% 79.74% +1.46%
===========================================
Files 53 55 +2
Lines 2656 3041 +385
===========================================
+ Hits 2079 2425 +346
- Misses 438 469 +31
- Partials 139 147 +8
Continue to review full report at Codecov.
|
John-Lin
suggested changes
Aug 18, 2018
src/entity/deployment.go
Outdated
| ID bson.ObjectId `bson:"_id,omitempty" json:"id" validate:"-"` | ||
| Name string `bson:"name" json:"name" validate:"required,k8sname"` | ||
| Namespace string `bson:"namespace" json:"namespace" validate:"required"` | ||
| Labels map[string]string `bson:"labels,omitempty" json:"labels" validate:"required,dive,keys,alphanum,endkeys,required,alphanum"` |
| }, | ||
| } | ||
| tName := namesgenerator.GetRandomName(0) | ||
| pod := entity.Deployment{ |
There was a problem hiding this comment.
variable name
deployment := entity.Deployment{
| NodeAffinity: []string{}, | ||
| Replicas: 1, | ||
| } | ||
| bodyBytes, err := json.MarshalIndent(pod, "", " ") |
There was a problem hiding this comment.
bodyBytes, err := json.MarshalIndent(deployment, "", " ")
| httpWriter := httptest.NewRecorder() | ||
| suite.wc.Dispatch(httpWriter, httpRequest) | ||
| assertResponseCode(suite.T(), http.StatusCreated, httpWriter) | ||
| defer suite.session.Remove(entity.DeploymentCollectionName, "name", pod.Name) |
There was a problem hiding this comment.
defer suite.session.Remove(entity.DeploymentCollectionName, "name", deployment.Name)
|
|
||
| //load data to check | ||
| retDeployment := entity.Deployment{} | ||
| err = suite.session.FindOne(entity.DeploymentCollectionName, bson.M{"name": pod.Name}, &retDeployment) |
There was a problem hiding this comment.
err = suite.session.FindOne(entity.DeploymentCollectionName, bson.M{"name": deployment.Name}, &retDeployment)
| suite.NoError(err) | ||
| suite.NotEqual("", retDeployment.ID) | ||
| suite.Equal(pod.Name, retDeployment.Name) | ||
| suite.Equal(len(pod.Containers), len(retDeployment.Containers)) |
There was a problem hiding this comment.
suite.Equal(len(deployment.Containers), len(retDeployment.Containers))
| err = json.Unmarshal(httpWriter.Body.Bytes(), &pod) | ||
| suite.NoError(err) | ||
| suite.Equal(tName, pod.Name) | ||
| suite.Equal(len(containers), len(pod.Containers)) |
There was a problem hiding this comment.
suite.Equal(len(containers), len(deployment.Containers))
| pod = entity.Deployment{} | ||
| err = json.Unmarshal(httpWriter.Body.Bytes(), &pod) | ||
| suite.NoError(err) | ||
| suite.Equal(tName, pod.Name) |
There was a problem hiding this comment.
suite.Equal(tName, deployment.Name)
| assertResponseCode(suite.T(), http.StatusOK, httpWriter) | ||
|
|
||
| pod = entity.Deployment{} | ||
| err = json.Unmarshal(httpWriter.Body.Bytes(), &pod) |
There was a problem hiding this comment.
err = json.Unmarshal(httpWriter.Body.Bytes(), &deployment)
| }, | ||
| } | ||
| tName := namesgenerator.GetRandomName(0) | ||
| pod := entity.Deployment{ |
There was a problem hiding this comment.
deployment := entity.Deployment{
John-Lin
approved these changes
Aug 20, 2018
John-Lin
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeletePropagationForegroundto delete deployment.