[Task] VX-271: Log handler which responses the logs of the containers #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #258 +/- ##
===========================================
- Coverage 79.41% 78.77% -0.65%
===========================================
Files 55 58 +3
Lines 3027 3232 +205
===========================================
+ Hits 2404 2546 +142
- Misses 469 523 +54
- Partials 154 163 +9
Continue to review full report at Codecov.
|
John-Lin
suggested changes
Aug 18, 2018
|
|
||
| result, err := container.GetLogDetails(sp, namespace, podID, containerID, logSelector, usePreviousLogs) | ||
| if err != nil { | ||
| fmt.Errorf("failed to get the details of node: %v", err) |
John-Lin
reviewed
Aug 18, 2018
src/kubernetes/containers.go
Outdated
| ) | ||
|
|
||
| // GetContainer will get the container object by the container name | ||
| func (kc *KubeCtl) GetContainer(name string, podname string, namespace string) (*corev1.Container, error) { |
There was a problem hiding this comment.
This function seems not to be used?
WakeupTsai
changed the title
WakeupTsai
force-pushed
the
phstsai/VX-271
branch
from
6c5ba9f to
6f86cba
Compare
WakeupTsai
changed the title
John-Lin
approved these changes
Aug 22, 2018
John-Lin
approved these changes
Aug 22, 2018
hwchiu
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.