[Task] container exec #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #259 +/- ##
===========================================
- Coverage 74% 71.23% -2.77%
===========================================
Files 64 66 +2
Lines 3781 3928 +147
===========================================
Hits 2798 2798
- Misses 778 925 +147
Partials 205 205
Continue to review full report at Codecov.
|
John-Lin
force-pushed
the
johnlin/container-exec
branch
from
ea93362 to
bf63f88
Compare
WakeupTsai
reviewed
Aug 23, 2018
src/server/handler_shell.go
Outdated
| return | ||
| } | ||
|
|
||
| kubeconfigPath := filepath.Join(os.Getenv("HOME"), ".kube", "config") |
There was a problem hiding this comment.
這裡可以改從 serviceprovider 拿嗎？
There was a problem hiding this comment.
可以, 但是有一點點小麻煩因為現在 serviceprovider沒有存kubeconfigPath 或 下面一行的cfg
WakeupTsai
reviewed
Aug 23, 2018
src/server/handler_terminal.go
Outdated
| ) | ||
|
|
||
| if buf, err = session.Recv(); err != nil { | ||
| log.Printf("handleTerminalSession: can't Recv: %v", err) |
WakeupTsai
reviewed
Aug 23, 2018
|
|
||
| // startProcess is called by handleAttach | ||
| // Executed cmd in the container specified in request and connects it up with the ptyHandler (a session) | ||
| func startProcess(k8sClient kubernetes.Interface, cfg *rest.Config, request *restful.Request, cmd []string, ptyHandler PtyHandler) error { |
There was a problem hiding this comment.
如果用 serviceprovider 的話，這邊可以改成
func startProcess(sp *serviceprovider.Container, cfg *rest.Config, request *restful.Request, cmd []string, ptyHandler PtyHandler) error {
WakeupTsai
reviewed
Aug 23, 2018
| podName := request.PathParameter("pod") | ||
| containerName := request.PathParameter("container") | ||
|
|
||
| req := k8sClient.CoreV1().RESTClient().Post(). |
There was a problem hiding this comment.
req := sp.KubeCtl.Clientset.CoreV1().RESTClient().Post().
WakeupTsai
reviewed
Aug 23, 2018
src/server/route.go
Outdated
|
|
||
| router.PathPrefix("/api/sockjs").Handler(CreateAttachHandler("/api/sockjs")) |
|
8/28之後再來審視這個PR |
c9s
approved these changes
Sep 1, 2018
John-Lin
force-pushed
the
johnlin/container-exec
branch
3 times, most recently
from
bc96dec to
55af670
Compare
WakeupTsai
force-pushed
the
johnlin/container-exec
branch
from
55af670 to
7e74f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.