[Task] Update pod route #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sufuf3
force-pushed
the
sufuf3/update-route
branch
from
c503324 to
b6f729e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
- Coverage 79.38% 79.35% -0.03%
===========================================
Files 55 55
Lines 2993 2994 +1
===========================================
Hits 2376 2376
Misses 467 467
- Partials 150 151 +1
Continue to review full report at Codecov.
|
sufuf3
force-pushed
the
sufuf3/update-route
branch
from
fc1c55f to
b6f729e
Compare
|
Conflict |
sufuf3
force-pushed
the
sufuf3/update-route
branch
3 times, most recently
from
348f800 to
735d3b7
Compare
- Update route command of pod's init-container - Update network-controller image version from v0.4.0 to v0.4.3
sufuf3
force-pushed
the
sufuf3/update-route
branch
from
735d3b7 to
5ccf651
Compare
John-Lin
reviewed
Aug 20, 2018
src/entity/pod.go
Outdated
| IPAddress string `bson:"ipAddress" json:"ipAddress" validate:"required,ipv4"` | ||
| Netmask string `bson:"netmask" json:"netmask" validate:"required,ipv4"` | ||
| RoutesGw []PodRouteGw `bson:"routesGw,omitempty" json:"routesGw" validate:"dive"` | ||
| RoutesIntf []PodRouteIntf `bson:"routesIntf,omitempty" json:"routesIntf" validate:"dive"` |
src/entity/pod.go
Outdated
| VlanTag *int32 `bson:"vlanTag" json:"vlanTag" validate:"-"` | ||
| IPAddress string `bson:"ipAddress" json:"ipAddress" validate:"required,ipv4"` | ||
| Netmask string `bson:"netmask" json:"netmask" validate:"required,ipv4"` | ||
| RoutesGw []PodRouteGw `bson:"routesGw,omitempty" json:"routesGw" validate:"dive"` |
There was a problem hiding this comment.
I met CI fail if I use required,dive,required in validate.
John-Lin
reviewed
Aug 20, 2018
API.md
Outdated
| @@ -632,6 +620,11 @@ For each Pod, we have fileds need to handle. | |||
| - vlanTag: the vlan tag for `ifName` interface. | |||
| - ipADdress: the IPv4 address of the `ifName` interface. | |||
| - netmask: the IPv4 netmask of the `ifName` interface. | |||
| - routesGw: a array of route with gateway (Optional) | |||
| - dstCIDR: destination network cidr for add IP routing table | |||
API.md
Outdated
| - dstCIDR: destination network cidr for add IP routing table | ||
| - gateway: the gateway of the interface subnet | ||
| - routeIntf: a array of route without gateway (Optional) | ||
| - dstCIDR: destination network cidr for add IP routing table |
API.md
Outdated
| @@ -632,6 +620,11 @@ For each Pod, we have fileds need to handle. | |||
| - vlanTag: the vlan tag for `ifName` interface. | |||
| - ipADdress: the IPv4 address of the `ifName` interface. | |||
| - netmask: the IPv4 netmask of the `ifName` interface. | |||
| - routesGw: a array of route with gateway (Optional) | |||
| - dstCIDR: destination network cidr for add IP routing table | |||
| - gateway: the gateway of the interface subnet | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.