[Task] Update deploy route #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update route command - Update network-controller image from v0.4.0 to v0.4.3
Codecov Report
@@ Coverage Diff @@
## develop #262 +/- ##
===========================================
- Coverage 79.38% 79.35% -0.03%
===========================================
Files 55 55
Lines 2993 2994 +1
===========================================
Hits 2376 2376
Misses 467 467
- Partials 150 151 +1
Continue to review full report at Codecov.
|
John-Lin
suggested changes
Aug 20, 2018
src/entity/deployment.go
Outdated
| // DeploymentRoute is the structure for add IP routing table | ||
| type DeploymentRoute struct { | ||
| // DeploymentRouteGw is the structure for add IP routing table | ||
| type DeploymentRouteGw struct { | ||
| DstCIDR string `bson:"dstCIDR" json:"dstCIDR" validate:"required,cidrv4"` | ||
| Gateway string `bson:"gateway" json:"gateway" validate:"omitempty,ipv4"` |
There was a problem hiding this comment.
if DeploymentRouteGw is set both DstCIDR and Gateway are required
John-Lin
reviewed
Aug 20, 2018
API.md
Outdated
| @@ -632,6 +632,11 @@ For each Pod, we have fileds need to handle. | |||
| - vlanTag: the vlan tag for `ifName` interface. | |||
| - ipADdress: the IPv4 address of the `ifName` interface. | |||
| - netmask: the IPv4 netmask of the `ifName` interface. | |||
| - routesGw: a array of route with gateway (Optional) | |||
| - dstCIDR: destination network cidr for add IP routing table | |||
There was a problem hiding this comment.
dstCIDR(required): destination network cidr for add IP routing table
gateway(required): the gateway of the interface subnet
John-Lin
reviewed
Aug 20, 2018
API.md
Outdated
| - dstCIDR: destination network cidr for add IP routing table | ||
| - gateway: the gateway of the interface subnet | ||
| - routeIntf: a array of route without gateway (Optional) | ||
| - dstCIDR: destination network cidr for add IP routing table |
sufuf3
force-pushed
the
sufuf3/update-deploy
branch
from
09969a4 to
8ce434a
Compare
sufuf3
force-pushed
the
sufuf3/update-deploy
branch
from
8ce434a to
59e5e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.