[Task] Support the new type App #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
force-pushed
the
hwchiu/support-app
branch
from
da34f4e to
004290e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #266 +/- ##
==========================================
+ Coverage 79.41% 80.4% +0.98%
==========================================
Files 55 56 +1
Lines 3027 3276 +249
==========================================
+ Hits 2404 2634 +230
- Misses 469 485 +16
- Partials 154 157 +3
Continue to review full report at Codecov.
|
hwchiu
force-pushed
the
hwchiu/support-app
branch
from
dc2fa07 to
0d58c1f
Compare
John-Lin
suggested changes
Aug 21, 2018
src/server/handler_app.go
Outdated
|
|
||
| if err := session.Insert(entity.ServiceCollectionName, &p.Service); err != nil { | ||
| if mgo.IsDup(err) { | ||
| response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Deployment Name: %s already existed", p.Deployment.Name)) |
There was a problem hiding this comment.
response.Conflict(req.Request, resp.ResponseWriter, fmt.Errorf("Service Name: %s already existed", p.Service.Name))
… label name for deployment/service
John-Lin
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App is a new resource type and it will create the deployment and service in the same time.