Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Support the new API to get the port status of ovs. #280

Merged
merged 11 commits into from
Aug 28, 2018
Merged

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Aug 24, 2018

Implement a new restful api to get the port status of specific network.
It contains the PortID, receives packet counts and transmit packet counts.
We need to find a way to mapping the PortID to interface name and then the Pod Name later.
screen shot 2018-08-24 at 4 23 10 pm

@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #280 into develop will increase coverage by 0.09%.
The diff coverage is 86.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
+ Coverage    78.57%   78.67%   +0.09%     
===========================================
  Files           60       62       +2     
  Lines         3361     3404      +43     
===========================================
+ Hits          2641     2678      +37     
- Misses         547      551       +4     
- Partials       173      175       +2
Impacted Files Coverage Δ
src/ovscontroller/ovs_system.go 71.42% <71.42%> (ø)
src/server/route.go 84.61% <83.33%> (-0.07%) ⬇️
src/networkcontroller/network_controller.go 82.6% <84.61%> (+0.33%) ⬆️
src/server/handler_ovs.go 94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7a32c...11df4dd. Read the comment docs.

@@ -1633,3 +1635,44 @@ Response Data:
"message": "Delete success"
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

格式有錯?

@John-Lin
Copy link
Contributor

這個PR有需要更新 Vendor/vendor.json 嗎?

@hwchiu
Copy link
Contributor Author

hwchiu commented Aug 28, 2018

不需要,因為DumpPort本來就有了,新版的才需要更新

@hwchiu hwchiu merged commit 3d47c18 into develop Aug 28, 2018
@hwchiu hwchiu deleted the hwchiu/VX-62 branch August 28, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants