Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] VX-280: GetContainer API should require pod name #282

Merged
merged 3 commits into from
Aug 28, 2018

Conversation

WakeupTsai
Copy link
Contributor

@WakeupTsai WakeupTsai commented Aug 27, 2018

This PR will effect the front-end, please make sure front-end also merge the relative PR.

@codecov-io
Copy link

Codecov Report

Merging #282 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #282      +/-   ##
===========================================
+ Coverage    78.57%   78.61%   +0.03%     
===========================================
  Files           60       60              
  Lines         3361     3339      -22     
===========================================
- Hits          2641     2625      -16     
+ Misses         547      543       -4     
+ Partials       173      171       -2
Impacted Files Coverage Δ
src/prometheuscontroller/controller.go 86.71% <100%> (ø) ⬆️
src/server/route.go 84.55% <100%> (-0.13%) ⬇️
src/server/handler_prometheus.go 65.57% <100%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7a32c...2a7aa94. Read the comment docs.

@John-Lin
Copy link
Contributor

@hwchiu hwchiu merged commit 41494d1 into develop Aug 28, 2018
@hwchiu hwchiu deleted the phstsai/VX-280 branch August 28, 2018 09:04
@John-Lin John-Lin restored the phstsai/VX-280 branch August 28, 2018 09:23
@John-Lin John-Lin deleted the phstsai/VX-280 branch August 28, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants